chore: Build against Selenium nightly build in a separate nightly job#2391
Open
asolntsev wants to merge 1 commit intoappium:masterfrom
Open
chore: Build against Selenium nightly build in a separate nightly job#2391asolntsev wants to merge 1 commit intoappium:masterfrom
asolntsev wants to merge 1 commit intoappium:masterfrom
Conversation
asolntsev
requested review from
SrinivasanTarget,
mykola-mokhnach,
saikrishna321 and
valfirst
as code owners
Otherwise, we break build of every single PR when something is wrong with the Selenium nightly build.
asolntsev
force-pushed
the
build-against-selenium-nightly-only-at-night
branch
from
aef070f to
657f294
Compare
asolntsev
changed the title
Contributor
It looks like the compilation does not really work with these changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
Before:
GA was building against Selenium nightly build in every PR.
This is bad because it can break build of every single PR when something is wrong with the Selenium nightly build.
After:
GA has a dedicated nightly jobs that runs at 6:06 every night, and builds against the latests Selenium nightly build.
So we don't break builds of current PRs.
Types of changes